Topic: getting "quotes" from forum needs improving...

[runnerjp]

ok at the moments this is how i get a quote form the forum...


First i click the quote button which stores the post id

Code: [Select]

<form action="index.php?page=reply&forum=<?php echo $forum; ?>&id=<? echo
$forumpostid ?>" method="post">
        <input name="quote" type="hidden" value="<? echo $gettopic3['postid']; ?>" />
       <input name="submit" type="submit" value="quote" />
</form>

then on the reply page i do this

Code: [Select]

<textarea id="inputforum" class="inputforum" name='yourpost' rows='5' cols='40'><?php echo
$thePost;
 if (isset($_POST['quote']))
{
$quote = mysql_fetch_assoc(mysql_query("SELECT * from forumtutorial_posts where postid='".$_POST['quote']."'"));

?>[quote=<?php echo $quote['author'] ?> ] <?php echo $quote['post']; ?> [/quote] <?php


}?> </textarea>
so would you guys say this is the best way to do it or could it be improved??

[backie]

It could be improved by removing a $_POST var from being in escaped into the mysql statement.

Also you could think about having

which would link back to the post where the quote has been taken from.

[runnerjp]

dont get last part lol

[backie]

Yea the did forum code in a forum, wasn't thinking there.

Code: [Select]

[quote=author;postid]

Which would link back to the orginal post, or just have it quote=postid and have the backend retrive the author's name each time.

[runnerjp]

ok so just add the id into a link