File upload

ajicles · July 29, 2010

I need help with my upload script it doesn't want to do anything when button is submitted.

      <?php   

    if (isset($_POST['submitBtn'])){
require_once("includes/upload.php"); 
    }	



?>
      <div id="submitform">
      <h2>Upload:</h2>
        <form enctype="multipart/form-data" action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
          <input type="hidden" name="MAX_FILE_SIZE" value="1000000" /><br />
          Choose a file to upload:<br />
          <input name="uploaded_file" type="file" /><br />
          <input type="submit" value="Upload" /><br />
        </form>

upload.php

<?php

//Сheck that we have a file
if((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {
  //Check if the file is JPEG image and it's size is less than 350Kb
  $filename = basename($_FILES['uploaded_file']['name']);
  //$ext = substr($filename, strrpos($filename, '.') + 1);
  if (($_FILES["uploaded_file"]["size"] < 26214400)) {
    //Determine the path to which we want to save this file
      $newname = dirname(__FILE__).'/upload/'.$_SESSION['username'].''.$filename;
      //Check if the file with the same name is already exists on the server
      if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
           $ip_address = $_SERVER['REMOTE_ADDR'];
$file_hash = hash('ripemd160', '$filename');

echo 'Link to your file: <a href="http://localhost/filehosting/download.php?d='.$file_hash.'">http://localhost/filehosting/download.php?d='.$file_hash.'</a>';

$con = mysql_connect("localhost","root","");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("filehosting");

$sql="INSERT INTO data(ID, file_location, file_hash, file_ip_address) VALUES ('','$filename','$file_hash','$ip_address')";

if (!mysql_query($sql,$con))
  {
  die('Error: ' . mysql_error());
  }
mysql_close($con);
        } else {
           echo "Error: A problem occurred during file upload!";
        }
      } else {
         echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
      }
  } else {
     echo "Error: Only files under 25MBs are accepted for upload";
 echo 'Upgrade your account to upload bigger files.';
  }
} else {
echo "Error: No file uploaded";
}


?>

Pikachu2000 · July 29, 2010

Is this all one script?

ajicles · July 30, 2010

Is this all one script?

Well. When the uploade botton is pressed it loads the upload script and then executes it and puts in the variables with the data information.

If require_once("includes/upload.php"); wasn't inside of a if pressed command it would be like where the information and shoots errors and hopefully the error traps work lol.

mongoose00318 · July 30, 2010

I need help with my upload script it doesn't want to do anything when button is submitted.

      <?php   

    if (isset($_POST['submitBtn'])){
require_once("includes/upload.php"); 
    }	



?>
      <div id="submitform">
      <h2>Upload:</h2>
        <form enctype="multipart/form-data" action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
          <input type="hidden" name="MAX_FILE_SIZE" value="1000000" /><br />
          Choose a file to upload:<br />
          <input name="uploaded_file" type="file" /><br />
          <input type="submit" value="Upload" /><br />
        </form>

upload.php

<?php

//Сheck that we have a file
if((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {
  //Check if the file is JPEG image and it's size is less than 350Kb
  $filename = basename($_FILES['uploaded_file']['name']);
  //$ext = substr($filename, strrpos($filename, '.') + 1);
  if (($_FILES["uploaded_file"]["size"] < 26214400)) {
    //Determine the path to which we want to save this file
      $newname = dirname(__FILE__).'/upload/'.$_SESSION['username'].''.$filename;
      //Check if the file with the same name is already exists on the server
      if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
           $ip_address = $_SERVER['REMOTE_ADDR'];
$file_hash = hash('ripemd160', '$filename');

echo 'Link to your file: <a href="http://localhost/filehosting/download.php?d='.$file_hash.'">http://localhost/filehosting/download.php?d='.$file_hash.'</a>';

$con = mysql_connect("localhost","root","");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("filehosting");

$sql="INSERT INTO data(ID, file_location, file_hash, file_ip_address) VALUES ('','$filename','$file_hash','$ip_address')";

if (!mysql_query($sql,$con))
  {
  die('Error: ' . mysql_error());
  }
mysql_close($con);
        } else {
           echo "Error: A problem occurred during file upload!";
        }
      } else {
         echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
      }
  } else {
     echo "Error: Only files under 25MBs are accepted for upload";
 echo 'Upgrade your account to upload bigger files.';
  }
} else {
echo "Error: No file uploaded";
}


?>

Try this :

1) Remove the require_once()

2) Paste your upload file inplace of the require_once()

3) Instead of having if(isset($_POST['submitBtn'])) try this if(isset($_POST))

Let me know if that helps or not

inversesoft123 · July 30, 2010

if ($HTTP_POST_VARS['uploaded_file']) 
{
// code of upload.php or require_once("includes/upload.php"); 
} else {
// show form
}

Check actual submission of form.

Pikachu2000 · July 30, 2010

I've had some time to look this over, and actually, since your submit button has no name attribute, try simply giving it the name="submitBtn" attribute and see if that doesn't fix it. Also, you should get rid of the action="<?php echo $_SERVER['PHP_SELF']; ?>", as it's an XSS risk. Make it simply action=""

ajicles · July 30, 2010

Just when I get something working something else screws up lol. :wtf:

So, I made the necessary changes to my script.

	if(isset($_POST['submitBtn'])) 
{
	//Сheck that we have a file
	if((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {
  		//Check if the file is JPEG image and it's size is less than 350Kb
		 $filename = basename($_FILES['uploaded_file']['name']);
		 //$ext = substr($filename, strrpos($filename, '.') + 1);
		 if (($_FILES["uploaded_file"]["size"] < 26214400)) {
	   	//Determine the path to which we want to save this file
  	    $newname = dirname(__FILE__).'/upload/'.$_SESSION['username'].''.$filename;
     	//Check if the file with the same name is already exists on the server
      	if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
        $ip_address = $_SERVER['REMOTE_ADDR'];
	$file_hash = hash('ripemd160', '$filename');
	echo 'Link to your file: <a href="http://localhost/filehosting/download.php?d='.
	$file_hash.'">http://localhost/filehosting/download.php?d='.$file_hash.'</a>';
	$con = mysql_connect("localhost","root","");

	if (!$con)
  		{
  			die('Could not connect: ' . mysql_error());
  		}

	mysql_select_db("filehosting");

	$sql="INSERT INTO data(ID, file_location, file_hash, file_ip_address) VALUES ('','$filename','$file_hash','$ip_address')";

	if (!mysql_query($sql,$con))
  		{
  			die('Error: ' . mysql_error());
  		}
	mysql_close($con);

	} else {
        
		echo "Error: A problem occurred during file upload!";
    	}
    	} else {
         	echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
    	}
	} else {
     		echo "Error: Only files under 25MBs are accepted for upload";
 		echo 'Upgrade your account to upload bigger files.';
  		}
	} else {
			echo "Error: No file uploaded";
	}

	} else {
		echo "<h2>Upload:</h2>
     	   	<form enctype='multipart/form-data' action=' method='post'>
       	  	<input type='hidden' name='MAX_FILE_SIZE' value='1000000' /><br />
          	Choose a file to upload:<br />
          	<input name='uploaded_file' type='file' /><br />
          	<input type='submit' value='Upload' /><br />
        	</form>";
	}

And now when I press the submit button, it redirects me to: http://localhost/FileHosting/method=?MAX_FILE_SIZE=1000000&uploaded_file=text.txt

I tried if(isset($_POST)) and if(isset($_POST['submitBtn'])) and if ($HTTP_POST_VARS['uploaded_file'])

Only isset works :-\ I though the issue with the redirect error would be if(isset($_POST)) so I changed it back to if(isset($_POST['submitBtn']))

Thanks for your help so far guys

Pikachu2000 · July 30, 2010

You left out a quote at action='

ajicles · July 30, 2010

I am an idiot sometimes >:( Also dreamweaver tells me:

The document's current encoding can not correctly save all the of the characters within the document. You may want to change to UTF-8 or an encoding that supports the special characters in this document.

But that's the only error >_>.

Thanks for the help.

ajicles · July 30, 2010

Fix the last error and it still doesn't process any of the code after being submitted...

	if(isset($_POST)) 
{
		echo "<h2>Upload:</h2>
     	   	<form enctype='multipart/form-data' action='' method='post'>
       	  	<input type='hidden' name='MAX_FILE_SIZE' value='1000000' /><br />
          	Choose a file to upload:<br />
          	<input name='uploaded_file' type='file' /><br />
          	<input type='submit' value='Upload' /><br />
        	</form>";		
	} else {
//Сheck that we have a file
	if((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {
  		//Check if the file is JPEG image and it's size is less than 350Kb
		 $filename = basename($_FILES['uploaded_file']['name']);
		 //$ext = substr($filename, strrpos($filename, '.') + 1);
		 if (($_FILES["uploaded_file"]["size"] < 26214400)) {
	   	//Determine the path to which we want to save this file
  	    $newname = dirname(__FILE__).'/upload/'.$_SESSION['username'].''.$filename;
     	//Check if the file with the same name is already exists on the server
      	if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
        $ip_address = $_SERVER['REMOTE_ADDR'];
	$file_hash = hash('ripemd160', '$filename');
	echo 'Link to your file: <a href="http://localhost/filehosting/download.php?d='.
	$file_hash.'">http://localhost/filehosting/download.php?d='.$file_hash.'</a>';
	$con = mysql_connect("localhost","root","");

	if (!$con)
  		{
  			die('Could not connect: ' . mysql_error());
  		}

	mysql_select_db("filehosting");

	$sql="INSERT INTO data(ID, file_location, file_hash, file_ip_address) VALUES ('','$filename','$file_hash','$ip_address')";

	if (!mysql_query($sql,$con))
  		{
  			die('Error: ' . mysql_error());
  		}
	mysql_close($con);

	} else {
        
		echo "Error: A problem occurred during file upload!";
    	}
    	} else {
         	echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
    	}
	} else {
     		echo "Error: Only files under 25MBs are accepted for upload";
 		echo 'Upgrade your account to upload bigger files.';
  		}
	} else {
			echo "Error: No file uploaded";
	}
	}

inversesoft123 · July 30, 2010

	
<?php
if(isset($_POST)) 



{









//&#1057;heck that we have a file





if((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {
  





//Check if the file is JPEG image and it's size is less than 350Kb






$filename = basename($_FILES['uploaded_file']['name']);






//$ext = substr($filename, strrpos($filename, '.') + 1);






if (($_FILES["uploaded_file"]["size"] < 26214400)) {




   



//Determine the path to which we want to save this file
  



    $newname = dirname(__FILE__).'/upload/'.$_SESSION['username'].''.$filename;
     



//Check if the file with the same name is already exists on the server
      



if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
        $ip_address = $_SERVER['REMOTE_ADDR'];





$file_hash = hash('ripemd160', '$filename');





echo 'Link to your file: <a href="http://localhost/filehosting/download.php?d='.





$file_hash.'">http://localhost/filehosting/download.php?d='.$file_hash.'</a>';





$con = mysql_connect("localhost","root","");





if (!$con)
  





{
  







die('Could not connect: ' . mysql_error());
  





}





mysql_select_db("filehosting");





$sql="INSERT INTO data(ID, file_location, file_hash, file_ip_address) VALUES ('','$filename','$file_hash','$ip_address')";





if (!mysql_query($sql,$con))
  





{
  







die('Error: ' . mysql_error());
  





}





mysql_close($con);








} else {
        







echo "Error: A problem occurred during file upload!";
    



}
    



} else {
         



echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
    



}





} else {
     





echo "Error: Only files under 25MBs are accepted for upload";









echo 'Upgrade your account to upload bigger files.';
  





}





} else {








echo "Error: No file uploaded";





}








} else {

echo "<h2>Upload:</h2>
     



   



<form enctype='multipart/form-data' action='' method='post'>
       



  



<input type='hidden' name='MAX_FILE_SIZE' value='1000000' /><br />
          



Choose a file to upload:<br />
          



<input name='uploaded_file' type='file' /><br />
          



<input type='submit' value='Upload' /><br />
        



</form>";






}
?>

ajicles · July 30, 2010

	
<?php
if(isset($_POST)) 



{









//&#1057;heck that we have a file





if((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {
  





//Check if the file is JPEG image and it's size is less than 350Kb






$filename = basename($_FILES['uploaded_file']['name']);






//$ext = substr($filename, strrpos($filename, '.') + 1);






if (($_FILES["uploaded_file"]["size"] < 26214400)) {




   



//Determine the path to which we want to save this file
  



    $newname = dirname(__FILE__).'/upload/'.$_SESSION['username'].''.$filename;
     



//Check if the file with the same name is already exists on the server
      



if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
        $ip_address = $_SERVER['REMOTE_ADDR'];





$file_hash = hash('ripemd160', '$filename');





echo 'Link to your file: <a href="http://localhost/filehosting/download.php?d='.





$file_hash.'">http://localhost/filehosting/download.php?d='.$file_hash.'</a>';





$con = mysql_connect("localhost","root","");





if (!$con)
  





{
  







die('Could not connect: ' . mysql_error());
  





}





mysql_select_db("filehosting");





$sql="INSERT INTO data(ID, file_location, file_hash, file_ip_address) VALUES ('','$filename','$file_hash','$ip_address')";





if (!mysql_query($sql,$con))
  





{
  







die('Error: ' . mysql_error());
  





}





mysql_close($con);








} else {
        







echo "Error: A problem occurred during file upload!";
    



}
    



} else {
         



echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
    



}





} else {
     





echo "Error: Only files under 25MBs are accepted for upload";









echo 'Upgrade your account to upload bigger files.';
  





}





} else {








echo "Error: No file uploaded";





}








} else {

echo "<h2>Upload:</h2>
     



   



<form enctype='multipart/form-data' action='' method='post'>
       



  



<input type='hidden' name='MAX_FILE_SIZE' value='1000000' /><br />
          



Choose a file to upload:<br />
          



<input name='uploaded_file' type='file' /><br />
          



<input type='submit' value='Upload' /><br />
        



</form>";






}
?>

WHY does it have to be 497 lines long! :wtf:

inversesoft123 · July 30, 2010

LoL, its because of my code editor software, anyway I figured out what is the problem

1. $newname = dirname(__FILE__).'/upload/'.$_SESSION['username'].''.$filename;

Check here do you have directories at this location ?

inversesoft123 · July 30, 2010

	
<?php
if ($HTTP_POST_VARS['submit']) 
{

if((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {

	}
//Check if the file is JPEG image and it's size is less than 350Kb
$filename = basename($_FILES['uploaded_file']['name']);
//$ext = substr($filename, strrpos($filename, '.') + 1);
if (($_FILES["uploaded_file"]["size"] < 26214400)) {
//Determine the path to which we want to save this file
  $newname = dirname(__FILE__).'/upload/'.$filename;
//Check if the file with the same name is already exists on the server
     if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
        $ip_address = $_SERVER['REMOTE_ADDR'];
        $file_hash = hash('ripemd160', '$filename');
echo 'Link to your file: <a href="http://localhost/filehosting/download.php?d='.

$file_hash.'">http://localhost/filehosting/download.php?d='.$file_hash.'</a>';
$con = mysql_connect("localhost","root","");

if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }
mysql_select_db("filehosting");
$sql="INSERT INTO data(ID, file_location, file_hash, file_ip_address) VALUES ('','$filename','$file_hash','$ip_address')";
if (!mysql_query($sql,$con))
  {
  die('Error: ' . mysql_error());
  }
mysql_close($con);

} else {
        
echo "Error: A problem occurred during file upload!";
    
}
    } else {
         
echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
    
}

} else {
     echo "Error: Only files under 25MBs are accepted for upload";

echo 'Upgrade your account to upload bigger files.';
  
}
} else {

echo "<h2>Upload:</h2>
     <form enctype='multipart/form-data' action='test.php' method='post'>
       <input type='hidden' name='MAX_FILE_SIZE' value='1000000' /><br />
          Choose a file to upload:<br />
          <input name='uploaded_file' type='file' /><br />
          <input type='submit' name='submit' value='Upload' /><br />
        </form>";
}
?>

I have updated this code. and its working fine here.

just replace <form enctype='multipart/form-data' action='test.php' method='post'>

test.php here with your script name.

ajicles · July 30, 2010

Notice: Undefined variable: HTTP_POST_VARS in D:\wamp\www\FileHosting\upload.php on line 37

Line 37 is line 2 in your code you submitted.

Thanks for the help so far guy

inversesoft123 · July 30, 2010

The problem is that your PHP version and server probably don't support the deprecated $HTTP_POST_VARS collection. as you are running on Windows.. That's probably the source of the issue.

Try replacing with $_POST in your code

<?php
if ($_POST['submit']) 
{

if((!empty($_FILES["uploaded_file"])) && ($_FILES['uploaded_file']['error'] == 0)) {

}
//Check if the file is JPEG image and it's size is less than 350Kb
$filename = basename($_FILES['uploaded_file']['name']);
//$ext = substr($filename, strrpos($filename, '.') + 1);
if (($_FILES["uploaded_file"]["size"] < 26214400)) {
//Determine the path to which we want to save this file
  $newname = dirname(__FILE__).'/upload/'.$filename;
//Check if the file with the same name is already exists on the server
     if (!file_exists($newname)) {
        //Attempt to move the uploaded file to it's new place
        if ((move_uploaded_file($_FILES['uploaded_file']['tmp_name'],$newname))) {
        $ip_address = $_SERVER['REMOTE_ADDR'];
        $file_hash = hash('ripemd160', '$filename');
echo 'Link to your file: <a href="http://localhost/filehosting/download.php?d='.

$file_hash.'">http://localhost/filehosting/download.php?d='.$file_hash.'</a>';
$con = mysql_connect("localhost","root","");

if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }
mysql_select_db("filehosting");
$sql="INSERT INTO data(ID, file_location, file_hash, file_ip_address) VALUES ('','$filename','$file_hash','$ip_address')";
if (!mysql_query($sql,$con))
  {
  die('Error: ' . mysql_error());
  }
mysql_close($con);

} else {
        
echo "Error: A problem occurred during file upload!";
    
}
    } else {
         
echo "Error: File ".$_FILES["uploaded_file"]["name"]." already exists";
    
}



} else {
     echo "Error: Only files under 25MBs are accepted for upload";



echo 'Upgrade your account to upload bigger files.';
  
}
} else {






echo "<h2>Upload:</h2>
     <form enctype='multipart/form-data' action='upload.php' method='post'>
       <input type='hidden' name='MAX_FILE_SIZE' value='1000000' /><br />
          Choose a file to upload:<br />
          <input name='uploaded_file' type='file' /><br />
          <input type='submit' name='submit' value='Upload' /><br />
        </form>";
}
?>

ajicles · July 30, 2010

LoL, its because of my code editor software, anyway I figured out what is the problem

1. $newname = dirname(__FILE__).'/upload/'.$_SESSION['username'].''.$filename;

Check here do you have directories at this location ?

Yes. Also there is suppose to be a / separating the username and the filename lol.

ajicles · July 30, 2010

Thank you for all your help guys. My script is working greatly now. I had to change if ($_POST['submit']) to if (isset($_POST['submit'])). But thank you so much for your help

Pikachu2000 · July 30, 2010

$HTTP_POST_VARS was deprecated as of PHP 4.1.0, if I recall correctly. use $_POST.

Sign In

File upload

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Important Information