Jump to content

Can i make this more efficient


AdRock

Recommended Posts

I have some code which i think is really inefficient especially as there will be more more conditions to be met.

 

I was thinking about using s switch but don't know if this is possible or if it's best leaving as it is.

 

Any ideas?

 

if($parts[($i-1)]=="forum") {
            		//do some code
            	} 
            	else if($parts[($i-2)]=="forum") {
            		//do code
            	}
            	else if (($parts[($i-1)]=="list-messages") && (isset($parts[($i+1)]))) {
            		//do code
            	}
            	else {
               	 	// do some code
               	}

Link to comment
Share on other sites

More along the lines of

<?php
function doStuff($string) {
switch($string) {
	case "forum":
		return "display forum";
	break;
	case "list-messages":
		return "list all messages";
	break;
	default:
		return "don't know what to do";
	break;
}
}


for($x = 0; $x < count($parts); $x++) {
print doStuff($parts[$x]);
}
?>

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.