Array Range Function

[random1]

I've written the code to generate letter and number ranges:

 

public function generateRange($type = 'numbers', $start = 0, $end = 10)
{
	$rangelist = array();

	switch($type)
	{
		case 'upper letters':
		{
			foreach(range($start, $end) as $letter)
			{
				$rangelist[] = $letter;
			}
		}
		case 'lower letters':
		{
			foreach(range($start, $end) as $letter)
			{
				$rangelist[] = $letter;
			}
		}
		case 'numbers':
		{
			foreach(range($start, $end) as $number)
			{
				$rangelist[] = $number;
			}
		}
		default:
		{
			return false;
		}
		return $rangelist;
	}
}

 

It current doesn't seem to return the array result correctly currently.

 

If I change the line "$rangelist[] = $number;" to "echo $number;" it does print the correct data.

 

Any ideas on why the array return line isn't working correctly?

[salathe]

Remember to break after each case.

[random1]

I added in the break lines into my code:

 

public function generateRange($type = 'numbers', $start = 0, $end = 10)
{
	$rangelist = array();

	switch($type)
	{
		case 'upper letters':
		{
			foreach(range($start, $end) as $letter)
			{
				$rangelist[] = $letter;
			}
			break;
		}
		case 'lower letters':
		{
			foreach(range($start, $end) as $letter)
			{
				$rangelist[] = $letter;
			}
			break;
		}
		case 'numbers':
		{
			foreach(range($start, $end) as $number)
			{
				$rangelist[] = $number;
			}
			break;
		}
		default:
		{
			return false;
		}
		return $rangelist;
	}
}

 

Seems to still not work. Any ideas?

[salathe]

The return line is in the wrong place. Also, those {}s for each case are not necessary.

[random1]

Thanks

 

I've ended up with:

 

public function generateRange($type = 'numbers', $start = 1, $end = 10)
{
	$rangelist = array();

	switch($type)
	{
		case 'upper letters':
		{
			foreach(range($start, $end) as $letter)
			{
				$rangelist[] = $letter;
			}
			return $rangelist;
			break;
		}
		case 'lower letters':
		{
			foreach(range($start, $end) as $letter)
			{
				$rangelist[] = $letter;
			}
			return $rangelist;
			break;
		}
		case 'numbers':
		{
			foreach(range($start, $end) as $number)
			{
				$rangelist[] = $number;
			}
			return $rangelist;
			break;
		}
		default:
		{
			return false;
		}
	}
}

[salathe]

Is there something more to your code that you are choosing to hide? I only ask because at the moment your function is doing nothing more than an ordinary call to range would do.

[Mchl]

While you're at it could you please write functions that:

- turn all letters in a string to lowercase

- find maximum number among any number of variables

- sort array values

- turn PHP array into JSON string

 

I need these ASAP

 

 

[Pikachu2000]

While you're at it could you please write functions that:

- turn all letters in a string to lowercase

- find maximum number among any number of variables

- sort array values

- turn PHP array into JSON string

 

I need these ASAP

 

 

 

LULZ.