Cant figure this out, second pair of eyes please?

[Centurian]

Parse error: syntax error, unexpected '(', expecting T_STRING or T_VARIABLE or T_NUM_STRING...

 

I'm getting this error for this line:

if ((int)$row['loyalty']<20)

 

Thanks in advanced.

[Pikachu2000]

The error is probably before that line.

[Centurian]

echo "No result <BR>";

echo "SELECT * FROM ".$user."Crew";

}

 

 

 

while($row = mysql_fetch_array($result))

  {

 

if ((int)$row['loyalty']<20)

[PaulRyan]

Post all of you code, just a few lines here and there will not help us to help you.

 

Regards, PaulRyan.

[Centurian]

Sure, but its a pretty massive file. I'll post a good chunk of it.

 

Its part of a function I use in a game I'm making. Basically, it generates a description of a particular unit. It works by connecting to my MySQL database, grabbing the matching data, then using a bunch of if statements to find problems with it.

 

function getcomment($user,$id)
{

$con = mysql_connect("localhost","admin","******");
if (!$con)
{
echo "Could not connect.";
}

$lols = mysql_select_db("********", $con);
if (!$lols)
{
echo "Could not select database.";
}

$result = mysql_query("SELECT * FROM ".$user."Crew WHERE id = $id ");
if (!$result)
{
echo "No result <BR>";
}



while($row = mysql_fetch_array($result))
  {

if ((int)$row['loyalty']<20)
{
if ($row['rank']="XO")
	{
		return "$row['Name']." is openly mutinous towards you - s/he is not suitable as an XO.";
		goto endsub;
	}
else
	{
		return "$row['Name']." is unhappy with your leadership.";
		goto endsub;
	}

endsub:
}

mysql_close($con);
}

 

 

[Zurev]

Assuming it'll work if you switch it to that, also added an equals sign since you were setting the variable = XO everytime, you need to work on learning how variables work in double/single quotes and when concatenation is required.

 

if ($row['rank']=="XO")
	{
		return $row['Name']." is openly mutinous towards you - s/he is not suitable as an XO.";
		goto endsub;
	}
else
	{
		return $row['Name']." is unhappy with your leadership.";
		goto endsub;
	}

 

More on your variables in strings....

("SELECT * FROM ".$user."Crew WHERE id = $id ")

 

That's a prime example right there - why did you leave the quotes on one but not the other?

[Centurian]

Thanks, I Applied Zurevs advice:

function getcomment($user,$id)
{

$con = mysql_connect("localhost","jameswit","Jordan");
if (!$con)
{
echo "Could not connect.";
}

$lols = mysql_select_db("jameswit_starship", $con);
if (!$lols)
{
echo "Could not select database.";
}

$result = mysql_query("SELECT * FROM ".$user."Crew WHERE id = ".$id);
if (!$result)
{
echo "No result <BR>";
echo "SELECT * FROM ".$user."Crew";
}



while($row = mysql_fetch_array($result))
  {

if ((int)$row['loyalty']<20)
{
if ($row['rank']=="XO")
	{
		return $row['Name']." is openly mutinous towards you - s/he is not suitable as an XO.";
		goto endsub;
	}
else
	{
		return $row['Name']." is unhappy with your leadership.";
		goto endsub;
	}
}

  }

endsub:

mysql_close($con);
}

 

The Quotes were left because PHP was looking for a variable called '$userCrew' when I removed the dots, and I need to words joined with no space between them. The thing with the equals signs was just my inexperience with this language. Thanks for pointing that out.

 

I'm still getting the same error. 'Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/jameswit/www/www/MYSQL.php on line 106'

 

 

 

[Pikachu2000]

Why are you using goto in that function?

[Centurian]

The Goto is so I can add more if statements without getting two results. A bit superfluous though.

 

I found the problem, and it was even earlier than any of this code. But thanks for the help.

 

*fixed*

[Pikachu2000]

return immediately ends the execution of the function, so goto is rather useless in that context.