PHP Code Not Querying

[justlukeyou]

I have put together a query which is designed to display a single question from a database.  However, it currently displays all the questions (and notes and category).  The problem is I cant work out how to get it to display just the qid I am querying.

 

This should display phpquestion.php?qid=2 but it just displays all the question as does phpquestion.php?qid=7 etc

 

ini_set('display_errors', 1);
error_reporting(-1);


$query = "SELECT * FROM questions";

if(isset($_GET['question']))
{
$question = $_GET['question'];
$query .= " WHEN qid is '$qid' LIMIT 0, 1";
}

$result = mysql_query($query);

while($row = mysql_fetch_assoc($result))

{

$question = $row['question'];
$notes = $row['notes'];
$category = $row['category'];
$qid = $row['qid'];

echo "$question |
$notes |
$category </br> ";
} 

if ($_GET['qid'] == $qid ) {
echo 'Sorry, this question is not available.  Please visit our <a href="http://www.ukhomefurniture.co.uk">Homepage</a>.';
}

function sanitizeString($string)
{
return mysql_real_escape_string($string);
}

$question = sanitizeString($_GET['qid']);
$query .= " WHERE question is '%$qid%'";

// close connection 
mysql_close();



?>

[Maq]

You're using $qid before it is defined.

[justlukeyou]

Thanks, I've had problems with this before.

 

Can you advise me how I do this.

 

I have entered the following code, I thought thats how to define strings.

 

$qid = $row['qid'];

[Maq]

If you're getting it via HTTP(phpquestion.php?qid=2) then you would want to use something like:

$qid = mysql_real_escape_string($_GET['qid']);

[justlukeyou]

Thanks,

 

I tried that but I got even more confused, should I be listing it in a different order? I cant how I can define qid.

 

$query = "SELECT * FROM questions";

{
$qid = mysql_real_escape_string($_GET['qid']);
}

if(isset($_GET['question']))
{
$question = $_GET['question'];
$query .= " WHEN qid is '$qid' LIMIT 0, 1";
}

$result = mysql_query($query);

while($row = mysql_fetch_assoc($result))

{

$question = $row['question'];
$notes = $row['notes'];
$category = $row['category'];
$qid = $row['qid'];

echo "$question |
$notes |
$category </br> ";
} 

if ($_GET['qid'] == $qid ) {
echo 'Sorry, this question is not available.  Please visit our <a href="http://www.ukhomefurniture.co.uk">Homepage</a>.';
}

function sanitizeString($string)
{
return mysql_real_escape_string($string);
}

$question = sanitizeString($_GET['qid']);
$query .= " WHERE question is '%$qid%'";

// close connection 
mysql_close();

[Maq]

That's correct.  I'm not sure what you're trying to do.  What is happening now?  What exactly do you want to happen?

[justlukeyou]

HI,

 

I want the page to display an individual from a database using the 'qid' (ID).

 

Currently it dispalys everything in the database not by the number of the qid phpquestion.php?qid=7

[sasa]

change

if(isset($_GET['question']))
{
$question = $_GET['question'];
$query .= " WHEN qid is '$qid' LIMIT 0, 1";
}

to

if(isset($qid)
{
//$question = $_GET['question'];
$query .= " WHERE qid = '$qid'";
}

[justlukeyou]

Brilliant, thanks mate I shall try that.