Form validation

[anevins]

Hi there,

 

I've got a HTML textarea with the name attribute of 'review' and I've posted this into a variable called $review.

I want to say if the characters are less than 30, please enter more words etc.

 

The problem is, I get the if statement's error even when there are more than 30 characters.

 

Can anyone figure out why I'm getting this?

if ($review < 30){
echo '<p class="red">Review is too short, please enter at least 15 words</p>';
}

[Pikachu2000]

Use strlen(), not a value comparison.

[jamesjmann]

Echo $review to see if the variable is getting the string. Also print_r the post array to make sure the text areas value is getting registered. Thats a start...

[anevins]

I've now got this:

if (strlen($review) > 30){
echo '<p class="red">Review is too short, please enter at least 15 words</p>';
}

 

but I can't get the error message to appear now; if the characters are less than 30

[jamesjmann]

Echo $review to see if the variable is getting the string. Also print_r the post array to make sure the text areas value is getting registered. Thats a start...

 

I jusy forgot. Pika's right. U wanna use the strlen function, unless of course $review is an integer.

[jamesjmann]

I've now got this:

if (strlen($review) > 30){
echo '<p class="red">Review is too short, please enter at least 15 words</p>';
}

 

but I can't get the error message to appear now; if the characters are less than 30

 

Post the rest of ur script

[Pikachu2000]

Probably because you're using a 'greater than' comparison . . .  Also, do you want characters or words counted?

[lastkarrde]

if (strlen($review) < 30){
echo '<p class="red">Review is too short, please enter at least 15 words</p>';
}

[anevins]

I've echo'd the variable and there is data in it

[anevins]

I just want the characters, I'll post the rest of the code 1 second

[anevins]

Problem solved; I was using greater than instead of less than.

 

Thanks for your keen interests everyone.

[jamesjmann]

Problem solved; I was using greater than instead of less than.

 

Thanks for your keen interests everyone.

 

Haha wow. Shuda seen that one comin

[anevins]

Hi again,

I'm trying to do some form validation.

 

I want to say, if the input in the textarea is greater than 30 and less than 255 characters, do some stuff.

But I think something's wrong with my current if statement:

if ((strlen($review) < 255) && strlen(($review) > 30)){
...
}

 

As when I change the if statement to if(!empty($review)){ ... }, the if statement works.

 

Can you see what's wrong with my strlen if statement?

[Pikachu2000]

In what way doesn't it work? Have you echoed strlen($review) to see what the value is?

 

[Threads merged]

[anevins]

I can echo $review before the if statement, but as soon as PHP reaches that particular if statement, it stops

[Jnerocorp]

change:

 

if ((strlen($review) < 255) && strlen(($review) > 30)){

 

to

 

if (strlen($review) < 255) && strlen($review) > 30)){

[Pikachu2000]

You have unnecessary parentheses in the if() conditional.

 

if ( strlen($review) < 255 && strlen($review) > 30 ) {

[anevins]

Problem solved, thanks Jnerocorp and Pikachu

[jamesjmann]

You have a second parenthesis after the second strlen ("strlen((") I think you meant to put it after the second strlen ("strlen($review))"). In any case, its rather needless to enclose both strlen's in parenthesis. I would just write it as:

<?php
if (strlen($review) < 255 && strlen($review) > 30) {
//blahblahblahblah
} else {
//blahblahblahblah
}
?>