forum reply help?

[simmsy]

Hi can anyone help this is my forum reply code:

 

<?php

include "connect.php";

 

// Get value of id that sent from hidden field

$id=$_POST['id'];

 

// Find highest answer number.

$sql="SELECT MAX(a_id) AS Maxa_id FROM reply WHERE question_id='$id'";

$result=mysql_query($sql);

$rows=mysql_fetch_array($result);

 

// add + 1 to highest answer number and keep it in variable name "$Max_id". if there no answer yet set it = 1

if ($rows) {

$Max_id = $rows['Maxa_id']+1;

}

else {

$Max_id = 1;

}

 

// get values that sent from form

$a_name=$_POST['a_username'];

$a_answer=$_POST['a_reply'];

 

// Insert answer

$sql2="INSERT INTO reply(question_id, a_id, a_username, a_reply, a_date, a_time)VALUES('$id', '$Max_id', '$a_username', '$a_reply', CURDATE(), CURTIME())";

$result2=mysql_query($sql2);

 

if($result2){

echo "Successful<BR>";

echo "<a href='viewtopic.php?id=".$id."'>View your answer</a>";

 

// If added new answer, add value +1 in reply column

$sql3="UPDATE topic SET reply='$Max_id' WHERE id='$id'";

$result3=mysql_query($sql3);

 

}

else {

echo "ERROR";

}

 

mysql_close();

?>

 

and this is the error message anyone know why it gives this Thanks

 

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/fightwa1/public_html/addreply.php on line 10

 

please help

[dcro2]

Your mysql_query is probably failing, so add a check for failure:

 

// Find highest answer number.
$sql="SELECT MAX(a_id) AS Maxa_id FROM reply WHERE question_id='$id'";
$result=mysql_query($sql) or die("MySQL error: ".mysql_error());
$rows=mysql_fetch_array($result);

[simmsy]

well it lets me enter a numerous replies but in only one topic and says error when I try and reply on another topic any suggestions?

[dcro2]

Could you tell us what that error is after using my code?

[simmsy]

theres no physical error with the code now it just says ERROR which the code said to say if it didn't post the message. It allows me to reply on one topic only when I try other topics it just says ERROR?

[dcro2]

Alright, use this code and try again:

<?php
include "connect.php";

// Get value of id that sent from hidden field
$id=$_POST['id'];

// Find highest answer number.
$sql="SELECT MAX(a_id) AS Maxa_id FROM reply WHERE question_id='$id'";
$result=mysql_query($sql) or die("MySQL Error in '$sql': ".mysql_error());
$rows=mysql_fetch_array($result);

// add + 1 to highest answer number and keep it in variable name "$Max_id". if there no answer yet set it = 1
if ($rows) {
    $Max_id = $rows['Maxa_id']+1;
} else {
    $Max_id = 1;
}

// get values that sent from form
$a_name=$_POST['a_username'];
$a_answer=$_POST['a_reply'];

// Insert answer
$sql2="INSERT INTO reply(question_id, a_id, a_username, a_reply, a_date, a_time) VALUES('$id', '$Max_id', '$a_username', '$a_reply', CURDATE(), CURTIME())";
$result2=mysql_query($sql2) or die("MySQL Error in '$sql2': ".mysql_error());

echo "Successful<BR>";
echo "<a href='viewtopic.php?id=".$id."'>View your answer</a>";

// If added new answer, add value +1 in reply column
$sql3="UPDATE topic SET reply='$Max_id' WHERE id='$id'";
$result3=mysql_query($sql3) or die("MySQL Error in '$sql3': ".mysql_error());

mysql_close();
?>

[simmsy]

well it looks like its partly worked as I have a new error but it says this now:

 

MySQL Error in 'INSERT INTO reply(reply_id, a_id, a_username, a_reply, a_date, a_time) VALUES('2', '1', 'dfgdfg', 'dfgdfg', CURDATE(), CURTIME())': Duplicate entry '1' for key 1

 

any ideas how I get round this?

[dcro2]

Can you paste here how the reply table is structured? It looks like a_id is supposed to be UNIQUE or AUTO_INCREMENT and there's already a row with that a_id.

[simmsy]

Yea a_id is the primary key (int) and auto_increment

[dcro2]

Then stop trying to insert a row with an a_id that already exists. That's what the error says.

[simmsy]

but shouldnt it be +1 to that id row every time so should be different, theres where im getting mixed up on

[dcro2]

Ahhh, I think I know what your problem is. You're getting the MAX a_id but only where the question_id matches your $id, but a_id has to be unique even if the question_id is different. Just don't enter a value for a_id and let MySQL take care of it, since it's AUTO_INCREMENT.

// Insert answer
$sql2="INSERT INTO reply(question_id, a_username, a_reply, a_date, a_time) VALUES('$id', '$a_username', '$a_reply', CURDATE(), CURTIME())";
$result2=mysql_query($sql2) or die("MySQL Error in '$sql2': ".mysql_error());

 

and get rid of this section:

// Find highest answer number.
$sql="SELECT MAX(a_id) AS Maxa_id FROM reply WHERE question_id='$id'";
$result=mysql_query($sql) or die("MySQL Error in '$sql': ".mysql_error());
$rows=mysql_fetch_array($result);

// add + 1 to highest answer number and keep it in variable name "$Max_id". if there no answer yet set it = 1
if ($rows) {
    $Max_id = $rows['Maxa_id']+1;
} else {
    $Max_id = 1;
}

[simmsy]

yea that was part of the problem but also took out the last query too so now the code is and finally works, thanks alot for your help finally got there lol!

 

<?php

include "connect.php";

 

// Get value of id that sent from hidden field

$id=$_POST['id'];

 

// get values that sent from form

$a_username=$_POST['a_username'];

$a_reply=$_POST['a_reply'];

 

// Insert answer

$sql2="INSERT INTO reply(reply_id, a_username, a_reply, a_date, a_time) VALUES('$id', '$a_username', '$a_reply', CURDATE(), CURTIME())";

$result2=mysql_query($sql2) or die("MySQL Error in '$sql2': ".mysql_error());

 

echo "Successful<BR>";

echo "<a href='viewtopic.php?id=".$id."'>View your answer</a>";

 

mysql_close();

?>

[dcro2]

No problem. Good luck and keep learning!