Jump to content

Break in a recursive function


ankme

Recommended Posts

I have a function that searches first for a line in a file and then for a string in that line. If the string is not found, it concatenates the line with the next line and so on until it finds the string.

The following script works but it is time consuming. I want to put a "break" somewhere so that if the line is found, the foreach will break. Can someone please help and tell me how to do this? If I put the break before

the recursive call, it wont do the call. If I put it after, it wont get to the break.

Thanks!

 

function findEndTag($file, $line, $consolidatedLine)

{

  $endTagFound = strstr($consolidatedLine,"/>");

  if (!$endTagFound)

  {

  $fileContent = file($file);

  foreach ($fileContent as $i => $lineArray)

  {

  if ($lineArray == $line)

  {

  $consolidatedLine = $consolidatedLine." ".$fileContent[$i+1];

 

  return (findEndTag($file, $fileContent[$i+1], $consolidatedLine));

 

  }

  }

}

  else

  {

  return $consolidatedLine;

  }

}

Link to comment
Share on other sites

It seems like the logic behind the function should be modified. Instead of calling the function again to test the data you just read, why not test the data right away? Maybe switch it to:

 

<?php

function findEndTag($file, $line, $consolidatedLine) {
     $fileContent = file($file);
     foreach ($fileContent as $i => $lineArray) {
          if ($lineArray == $line) {
               $consolidatedLine = $consolidatedLine." ".$fileContent[$i+1];
               $endTagFound = strstr($consolidatedLine,"/>");
               if (!$endTagFound) {
                    return (findEndTag($file, $fileContent[$i+1], $consolidatedLine));
               } else {
                    return $consolidatedLine;
               }
          }
     }
}


?>

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.