HTML FROM + PHP + MySQL fault - suspected fault in PHP

[FreedomandDemocrazy]

Greetz,

 

 

I am trying to write a simple newsletter sign up form using HTML FORM + PHP + MySQL.

 

I seem to be having a problem getting it working and I suspect the issue is in my PHP code and was wondering if someone could take a look at it for me to see if they can spot any obvious mistakes.

 

<?php

$link = mysql_connect('localhost', 'testuser', 'pass1');

if (!$link) {

die('Could not connect: ' . mysql_error());

}

echo 'Connected successfully';

mysql_select_db("testdb", $link);

$sql="INSERT INTO newsletters(mens)

VALUES

('$_POST[e-mail]')";

if (!mysql_query($sql,$link))

{

die('Error: ' . mysql_error());

}

echo "Done!";

mysql_close($link);

?>

 

Note: My SQL Database is named "testdb", I have a table called "newsletters" and a field called "mens".

 

Kind regards.

[voip03]

Is your DB Connected successfully?

 

your code

$sql="INSERT INTO newsletters(mens)VALUES('$_POST[e-mail]')";

 

change to

$sql="INSERT INTO newsletters(mens) VALUES ('".$_POST[e-mail]."')";

 

PS: Please use the code tag next time.

[FreedomandDemocrazy]

That's a good point... I'm not sure if its connecting correctly. How can I check?

 

I tried your line of code, but it didn't work.. but this could be because I am not connected.

[Pikachu2000]

There was really nothing wrong with the way you had it to start with. When you start concatenating variables into strings when it isn't necessary, all you do is introduce a greater number of chances to make a typo.

 

The more common way to write it would be to leave array indices that are strings quoted, and use complex notation.

 

$sql="INSERT INTO newsletters(mens)VALUES('{$_POST['e-mail']}')";

[FreedomandDemocrazy]

I see.

 

I tried your line Pikachu, but it didn't work either. Perhaps the problem is else where - perhaps PHP is not connecting to the database.. How would I check this?

 

Note: I'm not getting "Connected Successfully".

Note: I'm new to PHP/SQL.. sorry.

[Pikachu2000]

You should be getting the "Connected Successfully" message regardless of whether the connection is successful or not. What are you getting? Anything at all?

[FreedomandDemocrazy]

I wasn't getting anything. Error log showed this:

 

PHP Fatal error:  Call to undefined function mysql_connect()

 

Google led me to someone who said you need the PHP MySQL module installed. Problem might be found.

[FreedomandDemocrazy]

Solved.

[Pikachu2000]

Just noticed you have a hyphen (AKA subtraction operator) in the value of an array key. Although it will usually work, it can have some unexpected results depending on how it's quoted. You'd be better off to omit it or use an underscore instead.