$_SESSION Doesn't Seem To Work...

[Channel6]

I've written a script where it counts the page impressions on my website.

 

When a visitor lands on the page, it counts their impression and then sets a $_SESSION so that if they reload or return to the page it doesn't count it again. But the problem is it sometimes does.

 

Does this mean that the $_SESSION isn't being set probably? That's what it seems to be. And if so, what would be the reason for that?

 

Here's my basic code:

 

if(isset($_SESSION['userid'])){ 
     $userid = $_SESSION['userid']; 
} 
else{ 
     $userid = rand(1000, 10000000); 
     $_SESSION['userid'] = $userid; 
} 

$date = date('Y-m-d'); 

$counters = mysql_query("SELECT * FROM counters 
WHERE userid='$userid' 
AND impressions='1' 
AND date='$date'") 
or die(mysql_error()); 

if(!mysql_num_rows($counters)){ 
     mysql_query("INSERT INTO counters 
     (userid, impressions, date) 
     VALUES('$userid', '1', current_date)") 
     or die(mysql_error()); 
} 

[AyKay47]

the return value for mysql_num_rows is an integer not a boolean value.. !mysql_num_rows is not valid..

 

if(mysql_num_rows($counters) == 0){ 
     mysql_query("INSERT INTO counters 
     (userid, impressions, date) 
     VALUES('$userid', '1', current_date)") 
     or die(mysql_error()); 
} 

[Buddski]

!mysql_num_rows is not valid..

It mightn't be perfect but it is still valid code.

$var = 0;
if (!$var) {
echo 'Works';
}

[Buddski]

Instead of creating a random number for each person who visits your site, why not log the IP address? This will remove the need for a session.

Just a thought

[Channel6]

Buddski,

 

That's what I originally did. But it turned out that somehow some visitors had more than 1 IP address, so it counted double... even up to 4 times as many views than it should have.

 

Any other suggestions?

[AyKay47]

Instead of creating a random number for each person who visits your site, why not log the IP address? This will remove the need for a session.

Just a thought

can't rely on that method as a user can have multiple ip adresses..

 

OP is your script still not working with the change that i suggested?

 

[Zane]

I don't see anywhere in your provided code where you are actually starting the session with session_start

 

On another note,

the return value for mysql_num_rows is an integer not a boolean value.. !mysql_num_rows() is not valid..

It is so valid.  What gave you the idea that it wasn't

The number of rows in a result set on success or FALSE on failure.

 

And if there are zero rows, well then 0 is the same a false.  If this were a mysql issue, I'd imagine the OP would have posted a mysql error.

[AyKay47]

I don't see anywhere in your provided code where you are actually starting the session with session_start

 

On another note,

the return value for mysql_num_rows is an integer not a boolean value.. !mysql_num_rows() is not valid..

It is so valid.  What gave you the idea that it wasn't

The number of rows in a result set on success or FALSE on failure.

 

And if there are zero rows, well then 0 is the same a false.  If this were a mysql issue, I'd imagine the OP would have posted a mysql error.

i stand corrected.. i forgot that it returns an int on success and FALSE on failure... how stupid of me..my apologies..