Jump to content

Issue with my Simple If statment


danjapro

Recommended Posts

 

I have this simple piece of code.

I am using GET[] to retrieve the catID from URL, then match it and set a backgorund image, some backgorund images can change per catID variable. When selected or clicked on.

 

It is not working, it is producing the catId in ech $_Get[], but not matching it with $filename to set correct Image.

 

Ex. Browser catID may == 1, it code displays catid = 1, file name = deals_2.jpg.

This is worng. should be catid = 1 , filename  = 1.

 

PLEASE HELP,  missing something.

<?php	
  $imgpath = '/shushmedeals/templates/shushme_deals/images/';
  //$bgimgID = $item->id;

  $bgimgID = isset($_GET['categoryId']);
  $bgimgID = $_GET['categoryId'];
  echo $bgimgID;
  //echo 'shoot her eman';
  //echo  $imgpath;

  if($bgimgID){
  	$bgimgID = 1;
$filename = '/shushmedeals/templates/shushme_deals/images/bg_home.jpg';
  } 
  if($bgimgID = 2){
  	$filename = '/shushmedeals/templates/shushme_deals/images/shushme_bg_img1.jpg';
  }
  if($bgimgID = 3){
  	 $filename = '/shushmedeals/templates/shushme_deals/images/shushme_bg_img2.jpg';
  } else {
  	 $filename = '/shushmedeals/templates/shushme_deals/images/shushme_bg_img3.jpg';
  }			 			 				  
  if($filename){ 
  	
  	echo '<br>'.$filename; 
  	// SET COOKIE 
  	//setcookie('bgimg',  $filename);	
  	//echo $_COOKIE['bgimg'];
  	
  } else { 
  	echo "There is no Background for this category"; 
  	// DO NOT SET COOKIE 
  } 


  // Print an individual cookie
  echo $_COOKIE["location"];
  
  ?>

 

Link to comment
Share on other sites

try this

 

<?php	
$imgpath = '/shushmedeals/templates/shushme_deals/images/';
//$bgimgID = $item->id;

$bgimgID = isset($_GET['categoryId']);
$bgimgID = $_GET['categoryId'];
echo $bgimgID;
//echo 'shoot her eman';
//echo  $imgpath;

if($bgimgID = 1) {
$filename = '/shushmedeals/templates/shushme_deals/images/bg_home.jpg';
} 
else {
if($bgimgID = 2){
	$filename = '/shushmedeals/templates/shushme_deals/images/shushme_bg_img1.jpg';
}
else {
	if($bgimgID = 3){
		$filename = '/shushmedeals/templates/shushme_deals/images/shushme_bg_img2.jpg';
	} else {
	$filename = '/shushmedeals/templates/shushme_deals/images/shushme_bg_img3.jpg';
	}
}
}

if($filename){ 
echo '<br>'.$filename; 
// SET COOKIE 
//setcookie('bgimg',  $filename);	
//echo $_COOKIE['bgimg'];
} 
else { 
echo "There is no Background for this category"; 
// DO NOT SET COOKIE 
} 


// Print an individual cookie
echo $_COOKIE["location"];

?>

 

EDIT: UPDATED

Link to comment
Share on other sites

Well, all of your IF statements are out of wack.

 

  if($bgimgID){
     $bgimgID = 1;
   $filename = '/shushmedeals/templates/shushme_deals/images/bg_home.jpg';
  } 
  if($bgimgID = 2){
     $filename = '/shushmedeals/templates/shushme_deals/images/shushme_bg_img1.jpg';
  }
// . . . 

The first if statement will be true as long as $bgimgID exists and cannot be interpreted as a boolean false (e.g. FALSE, 0, etc.). All the conditions that follow are ASSIGNMENTS not COMPARISONS. The second if() above is testing if you can assign the number 2 to the variable $bgimgID. That would return true every time.

 

You should probably be suing something like

  if($bgimgID == 1){
     $bgimgID = 1;
   $filename = '/shushmedeals/templates/shushme_deals/images/bg_home.jpg';
  } 
  if($bgimgID == 2){
     $filename = '/shushmedeals/templates/shushme_deals/images/shushme_bg_img1.jpg';
  }

 

Note the double equal signs for comparisons

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.