Foreach looping

[Xtremer360]

I'm trying to figure out what I'm doing wrong. For each recipient it runs each value which is an integer through the getUserByUserID function to verify that no values inside of the array are non users. But here's the part I'm not sure of and that's the if $recipient or $sender == FALSE. If ANY of the values are found to be non values then I want that if statement to activate.

 

foreach ($this->input->post('recipient[]') AS $recipient)
            {
                $this->users->getUserByUserID($recipient);
            }
            $sender = $this->users->getUserByUserID($this->input->post('sender'));
            
            // Verifies users were returned from database
            if (($recipient == FALSE) || ($sender == FALSE))
            {
                // Users was not found in the database
                $outputArray['message'] = 'Either the recipient or yourself could not be found in the database!';
            }

[scootstah]

$recipient is only going to be equal to the last iteration of the foreach loop. You need to do the check inside the foreach loop to check each item.

[Xtremer360]

So you are suggesting this:

 

// Retrieves users from database with posted user ids
            foreach ($this->input->post('recipient[]') AS $recipient)
            {
                $this->users->getUserByUserID($recipient);
                
                if ($recipient == FALSE) 
                {
                    $outputArray['message'] = 'One or more of the recipients could not be found in the database!';
                }
            }
            $sender = $this->users->getUserByUserID($this->input->post('sender'));
            
            if ($sender == FALSE)
            {
                $outputArray['message'] = 'You were for some reason not found in the database!';
            }
            

[scootstah]

Yes.

 

Though I think your logic is off a little. I don't think $recipient is ever going to be false.

 

Can you show me the getUserByUserId() method?

[Xtremer360]

I'm sorry it should have been NULL.

 

/**
 * Get user record by user id
 *
 * @param	int
 * @return	object
 */
    function getUserByUserId($userID)
    {
        $this->db->select('*');
	$this->db->where('userID', $userID);
	$query = $this->db->get('users');
        if ($query->num_rows() > 0)
        {
            $row = $query->row();
            return $row;
        } 
        else
        {
            return NULL;      
        } 
            
    }

[scootstah]

Okay, then you need to do something like

foreach ($this->input->post('recipient[]') AS $recipient)
{
if (!$this->users->getUserByUserID($recipient)) {
	$outputArray['message'] = 'One or more of the recipients could not be found in the database!';
}
}

 

There's a big problem with this though in that you will have a whole bunch of queries.

 

A better way would be to pass an array to a method that checks for all of the recipients all at once.