Get variable inside of function

[bsmedia]

I dont know why I'm having so many problems with this. I need to get a variable that defined in an included file inside of a function I've got this

 

Inside file.php I've got the $variable1 and $variable2 defined (they're dynamic/different to each user)

 

include('file.php');

 

function foo() {

GLOBAL $variable1, $variable2;

 

echo $variable1;

echo $variable2;

}

 

foo();

 

Yet it outputs nothing?

 

If I Include file.php right inside of the function it works however. Any idea?

 

[xyph]

<?php

$var1 = 'foo';
$var2 = 'bar';

function foo( $str1, $str2 ) {
echo $str1;
echo $str2;
}

foo( $var1, $var2 );

?>

 

Use arguments/returns rather than the global keyword.

[RickXu]

If the page you call foo() has included the file, the global would still work although it's not neat.

Like xyph suggested, you should stick to functions and returns or even consider putting them into classes if necessary.

[KevinM1]

Use arguments/returns rather than the global keyword.

 

Exactly right.  The word 'global' is evil.  Forget you ever saw it.

[KevinM1]

If the page you call foo() has included the file, the global would still work although it's not neat.

Like xyph suggested, you should stick to functions and returns or even consider putting them into classes if necessary.

 

Classes are NOT a stand-in for functions.  Classes have a specific use.